Please help! Final checks for bug fix release v5.3.5

Announcements
#1

We are planning a bug fix release v5.3.5 to resolve some issues we have discovered in v5.3.4.

I intend to make the release on Monday. That gives us three days to give it a thorough testing:

https://tiddlywiki.com/prerelease

It is frustrating that we found so many problems within days of the release of v5.3.4. It suggests that as a community we are not doing a good job of testing these new releases.

There is no question that the best way to flush out problems with a release is for as many users as possible to make a test upgrade of as many wikis as possible.

So, I would really appreciate as much attention on this as we can manage. Let’s try to avoid the ignominy of having to make a further v5.3.6 bug fix release…

3 Likes
#2

Thank you for addressing these bugs so quickly! I’m afraid I didn’t do my due diligence testing the last prerelease, but this one seems to fix (ETA: does not fix) the only issue I’d encountered with 5.3.4 so far (a non-fatal ‘Script error’ RSOE when deleting tiddlers in my most highly-customized wiki… possibly related to the $data bug that #8333 resolves? I hadn’t documented it well enough to report—and in any case, it appears to be fixed now.) I will keep testing!

May I also suggest either pinning this announcement or editing the previous pinned thread with a link to the prerelease and perhaps the prerelease upgrade site?

1 Like
#3

I too had recently experienced some javascript errors in trying to delete tiddlers, but it didn’t occur to me to connect it with the new release. Will poke around some more…

1 Like
#4

FWIW, I’ve briefly tested on my complex two main wikis and see no issues.

@jeremyruston , I think we should always include this link in these pre-release announcements (if you have an announcement template, consider revising it):

https://tiddlywiki.com/prerelease/upgrade

Apropos this recurring probem with bug-fixes just after the main release, I think it is partly a consequence of the semiannual release cycle that typically introduces so many goodies. I’m happy with this frequency but I wonder if the versioning form is not optimal for it. Maybe the semiannual release should be 5.3.40 and bugfix releases 5.3.41, or 5.3.4a → 5.3.4b etc?

Or maybe the last segment only could signify the bugfix so we actually do 5.34.1 where 34 is the semiannual release and the 1 is the bugfix/tweaking. So we semiannually celebrate 5.34 and that’s the official number (no need to modify any release banner).

#5

When editing a plugin and mistakenly removing a comma inside the json structure I get an RSOE. I’m curious why this would happen in edit mode? Is it a bug or to be expected?

#6

The only way I can imagine 8333 is to blame is if you have <$data $filter=...> widgets in your wiki. If you don’t then it very likely is a different issue.

Did it happen easily enough that you can test again with 5.3.4 and find a more definitive clue?

Same question. Were you trying the <$data $filter=...> widget?

#7

Yes, it happens every time I delete a tiddler from the story river. I’d thought there might be some connection because your $data widget bug seemed to affect missing tiddlers. But I hadn’t managed to track down the root cause of the error I’m getting, so I’m really just guessing. I’ll clean out as much unrelated content as I can and put a copy up on TiddlyHost in case anyone would like to take a look.

ETA: May take longer than I’d expected… in the process of removing “unrelated” plugin content, I also seem to have eliminated the error in my testing wiki. (Perhaps this happened inadvertently while I was testing the prerelease as well? It’s worth noting, I think, that I started encountering the delete error when I upgraded to 5.3.4; I’d been using the same set of plugins without issue in 5.3.3.) I’ll keep looking.

#8

You’re right - and not an issue resolved by the current prerelease. I seem to have accidentally “removed” the issue in the lighter version of my wiki I was using for testing. The feature-complete version still has the same error in 5.3.5-pre.

image
image776×282 9.71 KB

#9

Here’s a live demo of the error I’m encountering: https://delete-rsoe-534.tiddlyhost.com/

While testing to see which plugins I could safely remove, I discovered that removing TiddlyMap also seems to “solve” the problem. I hadn’t had any issues with it prior to the 5.3.4 upgrade, and had not made any changes to TiddlyMap or my page layout since upgrading.

#10

This error is thrown in title: $:/plugins/felixhayashi/tiddlymap/js/AbstractRefEdgeTypeSubscriber which is an uglified library. Libraries like this show up as 1 line in the debugger.

So there is no easy way to find out what really causes the problem. But it’s the plugin.

#11

It would be helpful if you could test TiddlyMap with an otherwise uncustomized empty.html and see if the error still occurs. I am not familiar enough with TiddlyMap to be able to do that in a meaningful manner.

#12

I did some more test and TiddlyMap does not work since v5.3.1, where it started to show initialization problems.

TW v5.3.4 loads it, but the library accesses a variable “p” that does not exist.

I did compile the TiddlyMap plugin from source and it seems to fix the “delete tiddler” problem. @etardiff I’ll send you a private post with JSON attached for testing.

But I do not know if TiddlyMap itself still works, since I do not know / use it.

1 Like
#13

I do see the logic; the most recent 5 releases have all required a bug fix release. There are counterarguments, though. Users might come away with the impression that a v5.x.0 release would necessarily be unreliable, making them inclined to wait for the v5.x.1 release. That runs counter to our goal of getting as much battle testing done as possible for each new release.

Thank you, I hadn’t come across that problem. It’s a long standing issue, but the fix is very straightforward so I am merging it for v5.3.5:

Thanks @pmario. It would be good to get TiddlyMap working again.

#14

I think tiddlymap issue must be brought to the notice of @Flibbles since he is trying to maintain that project. I have also noticed this error while trying to delete a tiddler, but only after upgrading to 5.3.4

1 Like
#15

I did raise an issue at GH already: RSOD with TW v5.3.5-pre - missing type · Issue #457 · felixhayashi/TW5-TiddlyMap · GitHub

2 Likes
#16

Thank you for testing and compiling this solution, @pmario! It does seem to resolve the error in 5.3.4 and 5.3.5-pre, and TiddlyMap still works for me.

I hadn’t noticed any issues with TiddlyMap in 5.3.3(-), but it’s very possible it was failing in some silent way that didn’t trigger an error message and didn’t impede my usage.

I really appreciate the diagnostic help! @Springer, is it possible that you’re also using TiddlyMap, or should we keep looking for a different issue?

#17

I can confirm it’s not TiddlyMap in my case. Alas, I failed to pay attention enough to noting the conditions so that I could revisit the problem, and I haven’t come across the RSOE again since this thread has been on my radar. So, I’m afraid I have to let the conversation move forward without more troubleshooting help from me.

1 Like
#18

Sorry, I know this is late; a long weekend intervened.

After fighting GigantiCorp’s latest productivity-blockers, I was able to test most of my wikis. I found no regressions whatsoever. But I haven’t paid close attention to the bugs from 5.3.4, so I can’t really tell you if it fixes anything.