I face the following error when pushing the “Make a PR” button at step 6:
“There was an error in creating the PR. TypeError: Failed to fetch dynamically imported module: https://cdn.pika.dev/@octokit/core”
Also, one suggestions to the process description: add direct links inside steps like:
I just tested it and did not encounter any errors. What browser and operating system are you using? Could you please try a test PR against the test repo by modifying any tiddler to confirm if the error happens again?
Do you use your browsers “private browsing” mode? … Any “add blockers” or “ghostery”, that may block access to certain pages.
I personally use “uBlock origin”, which was active as I did create the videos. So that should be fine. I’ll run a short test, to see where my octokit library comes from.
It also starts with cdn.pika.dev but then switches over and actually loads the stuff from cdn.skypack.dev, which seems to the new name of the same company.
How is your internet connection speed? …
My browser network info showed a “turtle-image” which is an indicator for “slow connection”. May be we really did ran into a timeout?
New test leads to the same error.
Regarding my configuration: I am on windows 10 with microsoft edge without any extension but behind a proxy. Internet connexion speed quite good.
Now that the PR was submitted, it has recieved some feedback.
What is the advised course of action for taking them into account and provide a new version of the proposed change taking into account the comments?
From my understanding, if I go through steps 4 to 7 again, this will be a new PR without any link to the previous one. This may not be the expected behaviour.
Just tried to make the new PR but I face the following error
“There was an error in creating the PR. HttpError: Not Found”
when targetting official TW repository.
I have no error if I select the test repository.
As a side request, could you make the PR title and message persistent (storing there value in state tiddlers not temp tiddler) to allow easy saving of the PR for later and avoiding writing everything again when something goes wrong.
Step 5) Backup should have that covered. The temp tiddlers are exported. You only need to check them in the import dialogue. … But you are right. That could be improved.
I did just try to create a PR to the main repo. It worked for me
You could also do a SHIFT - F5 browser tab reload, to be sure, that you use the latest “tw5-docs-pre-maker” wiki. May be the browser cached it. .. That sometimes happens for me for pinned tabs.
Making the PR against official environment failed each time. Here are the information gathered in the console. Differents errors messages on different tries:
Online: each time
request.js:35
Failed to load resource: the server responded with a status of 404 ()
Online: once
saqimtiaz.github.io/:1
Failed to load resource: the server responded with a status of 405 ()
Local
api.github.com/repos/es-kha/TiddlyWiki5/git/refs:1
POST https://api.github.com/repos/es-kha/TiddlyWiki5/git/refs 404
Failed to load resource: the server responded with a status of 404 ()
