[tw5] 20+ tiddlers overwritten by node with lazy loading

khalfaniw · April 19, 2022, 11:52pm

A bunch of files with the same tag appear overwritten. They won’t load when I select them and the contents (except meta data) is empty in the node files.

All the files affected have the same tiddler tag. I set the tiddler to be a system tiddler so it would autoload in the side bar.

Markdown files that are now empty have a meta file that says _is_skinny at the top.
All the tiddler files that have been over written say _is_skinny: at the top for example example:

_is_skinny:
created: 20220331194245560
creator: khalfani
modified: 20220419190910674
modifier: khalfani
tags: $:/Bookmark
title: Notes
type: text/vnd.tiddlywiki

Is it supposed to work like this or should I try to recover these using my backup?

Also Is there another way to make a sidebar tiddler autoload without making it a system tiddler?

khalfaniw · April 19, 2022, 11:55pm

tiddlywiki --version 5.1.23
OS=node is running ubuntu 16. Accessed in chrome on windows 10

khalfaniw · April 20, 2022, 12:39am

It looks like it’s related to this bug

github.com/Jermolene/TiddlyWiki5

[BUG] Renaming tiddler with lazy-loading enabled can delete other tiddlers' bodies

opened 09:32PM - 23 Jul 20 UTC

flibbles

When you rename a tiddler (say, from A to B), then any tiddler that references A… in its `tags` or `lists` field which is still skinny (it hasn't been loaded yet) will have its `text` field deleted. This is because the relinker will update the `tags` or `lists` field, but when it goes to save the tiddler, it doesn't have the text (because the server never gave it to the browser), so the browser ends up telling the server that the new text is an empty string. This is **especially problematic** if you have my *Relink* plugin installed, [since relinking is far more likely to occur](https://github.com/flibbles/tw5-relink/issues/20). **Fix** There are two ways to fix this as far as I can see: 1. **The easy way:** Program the browser to load any skinny tiddlers whose fields it must update before sending it back to the server to update. Easy, but I don't think a good solution. 2. **The hard-but-better-longterm-solution way:** Create a new SyncAdapter task, RenameTiddler. The renaming occurs on the server, and then maybe the server sends the browser a list of updated tiddlers. This seems like more work, but it's definitely **my** preferred solution, since it's the only way my *Relink* plugin could handle lazy-server renaming. *Relink* can change the bodies of tiddlers, but unless it eagerly loads *every* tiddler, it can't do its job on the browser. The server has to do it. I realize *Relink* isn't core Tiddlywiki's problem, but if we ever want to adopt better relinking in core, this is necessary. Does anybody have any idea how feasible solution 2 is? I'm not that familiar with the syncAdapter. -Flibbles

Is there any intention to fix this. If not can it be noted in the documentation?

joshuafontany · April 27, 2022, 3:24pm

This definitely seems like a bug, I would have to investigate more. Very few people in the online community seem to use lazy loading, so I apologize if this caused you to lose data. I hope you found a recent backup.

I have linked that bug back to this thread. I would not use lazy loading unless you are really seeing a large performance benefit with it turned on atm.