Tiddler Link (underline) too "long"

#21

This is the new macro code with \whitespace trim option in:

$___macros_alternative_toc.json (10.8 KB)

With this new appied code I recognized, that there is no gap anymore between the title and the transcluded ‘erstellt’ field:
grafik

Checked also toc-tabbed-internal-nav - it is ok:
grafik

So I add  

<!-- Anzeige Feld 'erstellt' im Inhaltsverzeichnis  --> 				
     @@<span style="font-size:0.7em;color:rgb(144, 238, 144);" > &nbsp; <$transclude field='erstellt'/></span>@@

to have a gab between the tiddler name and the transcluded field:
grafik

This will affect toc-tabbed-internal-nav with an additional line between:

grafik
grafik1365×457 47.1 KB

code:

<style>
.colortext {
   font-variant:small-caps;
   color: rgba(255, 201, 102, 0.8);}
</style>

<$macrocall
	$name="toc-tabbed-internal-nav"
	tag="test"
    sort="sortan[]"
	selectedTiddler=<<qualify "$:/temp/toc/selectedTiddler">>
	unselectedText="<p>@@.colortext ← Thema wählen@@</p>"
	missingText="<p>@@.colortext Tiddler fehlt...@@</p>"
/>

How can this be fixed?

Thanks
Stefan

#22

If you add the erstellt-field to Test 8, 9 and 10 it will be shown in the empty space below the tiddler. May be your tiddlers don’t have that field so it’s shown as empty. …

I don’t know, which palette you use. So I can’t recreate the screenshots in the same way as yours. I did use the Twilight-palette for my screenshots. If the tiddlers have the erstellt-field it looks like this:

image
image788×370 6.11 KB

That’s probably not what you want, but what the changes in the macros created. … The toc-tabbed-internal-nav internally use the toc-selective-expandable macro … So whatever is added there will also show up in toc-tabbed-xxx macros

Instead of using text like &nbsp for styling CSS classes should be used.

Several utility classes like tc-tiny-gap-left or tc-small-gap-left have been added to the core base stylesheets, to be used by plugin authors.

The following changes should fix your first problem with the text gap.

    <span style="font-size:0.7em;color:rgb(144, 238, 144);" class="tc-tiny-gap-left" ><$transclude field='erstellt'/></span>

See all “gap” utility classes: https://github.com/Jermolene/TiddlyWiki5/blob/f87ab06414c921448b4a41bb38bc9739cf95555f/themes/tiddlywiki/vanilla/base.tid#L3095-L3132

Your JSON file misses some icons: $:/core/images/caret-right and $:/core/images/angle-down, which makes it hard for me to test your code.

We (the devs) need to add some documentation for those classes, so users know about them, so they can use proper CSS classes for styling instead of whitespace text.

You should describe in plain text, what you expect from the toc-tabbed-xx macros. … So we can have a closer look, what we can do there.

#23

Your macro call should look like this:

<$macrocall
	$name="toc-tabbed-internal-nav"
	tag="test"
    sort="sortan[]"
	selectedTiddler=<<qualify "$:/temp/toc/selectedTiddler">>
	unselectedText="""<p class="colortext"> ← Thema wählen</p>"""
	missingText="""<p class="colortext"> Tiddler fehlt...</p>"""
/>

the @@ shouldn’t be needed. … The same thing is true for the macro code. There shouldn’t be any @@ signs. … but that can be fixed later

#24

Thanks for feedback @pmario.

You are right.

Tiddlers with individual created date (=‘erstellt’ field) should be listed.
For those I use toc-selective-expandable.

(add the code you mentioned:
<span style="font-size:0.7em;color:rgb(144, 238, 144);" class="tc-big-gap-left" ><$transclude field='erstellt'/></span> )

Result ok:
grafik

For tiddlers without ‘erstellt’ field I use toc-tabbed-internal-nav.
grafik

Issue: There is no need to reserve space in an extra line
(as it was before adding \whitespace trim pragma inside every macro definition)

My wish: It should look like this:
grafik

Your JSON file misses some icons: $:/core/images/caret-right and $:/core/images/angle-down, which makes it hard for me to test your code.

This is just “look and feel” related.
grafik

Thanks
Stefan

#25

That’s not true. … If you remove the \whitespace trim and add your modified macro to tiddlywiki.com the toc-tabbed- macros are broken. They never worked with that modification.

#26

That’s not true. … If you remove the \whitespace trim and add your modified macro to tiddlywiki.com the toc-tabbed- macros are broken. They never worked with that modification.

I applied to an empty v5.2.3 Wiki my $:/_macros/alternative/toc.
As you can see, the tiddler link (underline) is too long again, but toc-tabbed-internal is proper shown:

grafik
grafik1026×651 25 KB

This is the Wiki (renamed from empty5.2.3.html to empty5.2.3.html.json):
empty5.2.3.html.json (2.2 MB)

Or did I understand anything wrong?

#27

You proved me wrong. … But I try to get it fixed in a global way.

I’m working on a post, that should show all users a way to implement a custom link, without the need to modify the core toc.

I’ll create a GH proposal, to allow the TOC to use “custom” open and closed-icons without the need to modify the core toc. …

The first modification won’t need any core changes. Only 3 new tiddlers will be needed.

The second proposal will need a change to the core. … But if it gets merged, we should be able to use custom icons too.

… Give me some time.

1 Like
#28

GH proposal: https://github.com/Jermolene/TiddlyWiki5/issues/6907

#29

That’s a prof of concept. … I’ll create a PR for this one. … BUT more testing will be needed.

image
image1481×1081 54 KB

#30

See this post with the info needed to create a custom link in the toc, without modifying the core plugin.

have fun!

PS: For your custom icons you will need to modify the plugin, but you don’t need the <span style= ... hack anymore.

#31

Thanks @pmario for this fast solution.

It works as expected - perfect! :smiley:

#32

@pmario:

Now is ‘erstellt’ field is also underlined - can this be removed?

grafik

Thanks
Stefan

#33

It’s part of the link, so the text and the date element will be clickable. That’s the standard behaviour. I think that shouldn’t be changed.

… Everything is possible, but the result is a much more complex template. Much more complex CSS settings and the core macro would need to be changed again. … I don’t see an easy way at the moment. …

I wanted to avoid to change the core macro, because it is error-prone as we found out.

Sorry Stefan – Ich nehme an, Du kennst das Sprichwort mit dem kleinen Finger und der Hand. (that’s not really translatable)

#34

@pmario, thanks for investigating into the issue :smiley:
Stefan