Issue using toc-selective-expandable with exclude

#1

As an experiment, I loaded up https://tiddlywiki.com/, changed the TableOfContents tiddler to have this:

<div class="tc-table-of-contents">

<<toc-selective-expandable 'TableOfContents' exclude:'[tag[done]]'>>

</div>

I then changed the Videos tiddler to have tag “done”. While this excluded the Videos tiddler under the Learning tiddler in the Contents tab, the “expandable arrow” disappears too, which seems like a bug?

Screenshot from 2025-02-21 16-30-36

If I remove the exclude clause (or the “done” tag), then it reverts correctly and the “expandable arrow” is back on the Learning tiddler title.

Screenshot from 2025-02-21 16-30-03

#2

That’s a known bug. There is no existing fix atm.

#3

Try my TiddlyTools alternative <<toc-tree>> macro (see TiddlyTools/TOC)

<div class="tc-table-of-contents">
<<toc-tree 'TableOfContents' exclude:'[tag[done]]'>>
</div>

The logic for when to show/hide the “expandable arrow” is defined in toc-toggle-item() and uses this filter:

<$list filter="[contains:$(field)$<item>] [list<item>] -[subfilter<exclude>] -[<item>] +[!has[draft.of]limit[1]]">

and correctly shows the arrow as long as at least one child item is contained in the branch.

I think that the bug in the TWCore’s <<toc-selective-expandable>> macro occurs in toc-linked-selective-expandable-body() in the filter on this line:

<$list filter="[all[current]tagging[]$sort$limit[1]] -[subfilter<__exclude__>]" ...

If this is changed to

<$list filter="[all[current]tagging[]$sort$] -[subfilter<__exclude__>] +[limit[1]]" ...

(i.e., so the exclusion is done before the limit[1] is applied), then it seems to fix the problem. Note that this same filter logic is also used in toc-unlinked-selective-expandable-body(), so that code would also need to be adjusted.

-e

#4

Thx @EricShulman

I did create a PR. Please test once the netlify preview version is built.

See: fix problem toc-selective-expandable by pmario · Pull Request #8959 · TiddlyWiki/TiddlyWiki5 · GitHub

2 Likes
#5

It looks good to me.

-e

3 Likes
#6

Many thanks all for fixing this.

2 Likes