Final Checks Before Release of v5.3.4

[XLBilly]

Looks like the color of the stability badges are fixed in the vanilla theme.

I think it is better to allow the color of the badges controlled by palettes (as the testcase widget), so that they can be themed.

For example stability badges can use solarized palette colors by adding these to the file:

stability-stable: #859900
stability-experimental: #b58900
stability-legacy: #268bd2
stability-deprecated: #dc322f

[Mohammad]

There is issue with transclude filter operator. See [BUG] TiddlyWiki 5.3.4 Prerelease: Transcluding Text References · Issue #8250 · Jermolene/TiddlyWiki5 (github.com)

[linonetwo]

Have you tried the plugin translation feature? You can switch language to zh-Hans and see menubar has Chinese translation.

@pmario you may want to add Germany translation to menubar plugin.

[jeremyruston]

@CodaCoder

This is an Azure VM running a test env Firefox (note the automation address bar) – bare bones, minimal install, almost no plugins, clean profile, zero cookies etc.

Thanks @CodaCoder your screenshot gave me the hint that the problem wasn’t Mac vs. Windows but rather about whether scrollbars are visible. I’ve just pushed a fix.

[CodaCoder]

[linonetwo]

@jeremyruston

rather about whether scrollbars are visible

I come across this bug in command palette plugin before. I was reusing core’s modal api to create mask, and scrollbar disappear when modal open, causing the whole page moving to the right, and causing style flashing that cause lagging.

So I’m using a homemade mask now.

[jeremyruston]

@Springer

With the tour: In addition to the disconcerting fact that users are specifically prompted to search for “help,” only to discover that apparently “there is none” (within that tour wiki) , there’s a weird thing at the end of the tour at the moment:

It seems to offer an additional/subsequent tour of the tag feature (after finishing the intro tour), but then that tour is over as soon as it starts.

Thanks @Springer I’ve posted the following fixes:

• Tour plugin: search for "home" instead of "help" · TiddlyWiki/TiddlyWiki5@153b66e · GitHub (home pleasingly matches both “Earth” and “Milky Way”)
• Tour plugin: remove unfinished "Using Tags" tour · TiddlyWiki/TiddlyWiki5@4cd6669 · GitHub
• Tour plugin: do not offer further tours if none are loaded · TiddlyWiki/TiddlyWiki5@93c9323 · GitHub

[jeremyruston]

@XLBilly

Looks like the color of the stability badges are fixed in the vanilla theme.

Thanks @XLBilly I’ve posted a fix here:

Stability badges: Use palette colours

[XLBilly]

The color attribute should also be changed in order to let the text of the badge use palette colors.

[jeremyruston]

@XLBilly

The color attribute should also be changed in order to let the text of the badge use palette colors.

Thank you @XLBilly fixed in Stability badges: further fix to palette usage · TiddlyWiki/TiddlyWiki5@cd8c483 · GitHub

[jeremyruston]

@vilc

The spacing in the tour plugin demo at https://tiddlywiki.com/prerelease/tour seems to have quite big spacing.

Thanks @vilc I’ve made some tweaks in Tour plugin: Improve layout · TiddlyWiki/TiddlyWiki5@0834891 · GitHub