Yes. Yes-ish. Meaning that the discussion about it is VERY complex.
TBH, at the end of it I’m no wiser than before.
SO I’ll trust you and @pmario and @jeremyruston to do whatever THEY think is best.
TT
See: Create Custom Lucide Icon Sets - #5 by pmario
The Lucide icons sets are basically finished. – There is only one thing left: Handling of Line Thickness using height and weight parameters. That’s the main reason, why I did not publish it till now.
4 Likes
Right. And I doubt there could ever be an exactly “right” answer to that outside of use cases.
In the context of TW I would/will accept as right (enough) your volition.
Getting this done, over, finished, will be useful IMO.
TT
I’ve created a PR for adopting Lucide icons:
See the preview here: https://deploy-preview-9366--tiddlywiki-previews.netlify.app/
I suggest that for backward-compatibility, the old icons should be available as an official plugin so that existing TiddlyWikis can preserve their current look-and-feel, especially if they are using custom icons that have been created or chosen to match the style and sizing of the current TWCore icon set.
-e
5 Likes
with a plugin of replacement icons one could edit them, perhaps adding a tag then disable the plugin, the edited ones will be tiddlers and override the core shadow tiddlers. just deleting the replacement icons would restore the core icons, and you could reenable the plugin if you needed to get a new icon.
perhaps a tool to assist?
I did deprecate the old icons to a plugin:
1 Like
I had a look at that, and the only comment I have is that the last example in the below permalink (changing the colour), did not work:
Changing “fill” to “color” is required.
Hi
Thanks for the hard work to everybody implied!
[Edited to explicitly address @XLBilly 's PR]
There are a few glitches in @XLBilly 's preview I’d like to point out:
Before (TW v5.3.8):
After (TW v5.4.0 prerelease):
I can live with the tags icon not really looking like the earth anymore, but the Warning icon has now a very low contrast and I find it barely legible, so I’d qualify it as a bug.
Regardless, I think the switch to Lucide is a great enhancement that I hoped would be merged since @pmario started to demo his work a few months ago.
Fred
@tw-FRed – I did just test
- the Lucide Core plugin and
- imported it to https://tiddlywiki.com/prerelease/
It works as expected. For me there is no glitch with the warning text as your screenshot shows.
No decision has been made, if v5.4.0 will use outline-based (my Lucide Core plugin) icons, which are bigger in size, or the path-based (Lucide native) icons, which are not 100% backwards compatible.
Both versions have their pros and cons as I pointed out at the GitHub issue
My plugin has been designed to be a drop in replacement for the core icons for all v5.3.x TW versions. … So even if they will not be used for v5.4.0 that’s OK. The plugin can be seen as a “backport” of the new icon set for all v5.3.x version.
IMO that’s a big advantage for all users that do not need / want to switch to v5.4.0 yet. They can still use the new icons without the need to update.
My Lucide Editions (there are 2) have the advantage, that they should also work with all 3rd party plugins, that use core icons in their code, out of the box. …
@tw-FRed … You are right. I should promote the editions and the plugins a bit more.
The Custom Icons Edition allows users to
- Create and manage their own custom icons sets as plugins.
- The edition uses local storage, to permanently store the plugins locally in your browser
- Existing icon sets can be imported to the edition and modified there
- The Lucide Core plugin is easy to use.
- Creating and managing your own plugins is a bit more complex. I’ll create a video for that one.
Have fun!
Mario
2 Likes
Absolutely! I did the same test and the result is good:
My comment was on @XLBilly 's preview here.
I should have explicitly said so, I’ll edit my post to avoid confusion.
Fred
Yes! You’ve made an amazing work on these editions, not only to modernize TW’s core icon set but also to allow users to enhance their wikis with other icons from Lucide set, thus keeping the same icon style throughout the wiki.
Whichever work, yours or @XLBilly’s, eventually gets merged in the core in replacement of original core icons, your Custom Icons Edition will remain of great value to add more icons in user wikis!
Fred
This is because the tw5.com edition’s stylesheet uses fill properties. Even though I purged fill properties in official themes and plugins in PR 9316 , there do exists backward incompatible problems if one applies styles with fill properties to outline based icons.
For the earth icon there exists two candidates, we may change the icon to the first one if most of the users can’t recognize the second icon.
If I understand, @XLBilly 's icons are native, path-based icons, and the incompatibilities appear when a CSS uses the fill property to set icon colors. OTOH, @pmario 's icons were converted to outline-based icons, which is 100% compatible but bigger in size.
Am I right?
Fred
Thanks for the clarification 
If I were asked to vote, I’d choose the first one, but maybe that’s because of my conservatism… 
I don’t know how it’s done, but maybe we could start a poll here on Talk?
Fred
@pmario 's implementation has another disadvantage: changing the line width of the icons uses a hacky way, while native lucide icons only requires setting the stroke-width attribute in SVG or setting stroke-width property in CSS.
hihi, I did use the first one, because I did not like the second one. For me it does not even look close to earth. The first one resembles longitude and latitude lines, which I did prefer.
So I think we should add both to new core-icons.
I also saw, that there are some new icons at tw-com. See the last 3 in the screenshot. I’ll need to update the lucide-core-pluign, with replacements for those.
