But is did not change the default shadow. I can not find the PR, that changed this value. … That’s strange.
IMO the default should be “Wrap long lines in code blocks : Yes” … We only needed to change this one for easy testing the PR.
Long lines should look like this. … So if your wiki shows text outside of the tiddler, you need to check your Style sheet settings.
I agree with this. I strongly prefer wrapping of code blocks by default. I don’t like having to use the horizontal scrollbar on all the codebody: yes tiddlers.
But if that is the way it has to be, I can configure it in all my wikis post 5.4
The only complaint I have so far is that the shadow $:/themes/tiddlywiki/vanilla/options/codewrapping text was changed from pre-wrap to pre in the core. This was an issue for me, because probably due to some of my modifications the pre setting doesn’t look well with longer code lines flowing out of the tiddler area to the right. Everything is as it used to be on the pre-wrap setting.
If the default setting was changed on purpose, I’m alright with that, I can imagine why the no wrap could be better as default.
I think it would make sense to revert this. The other change in the original PR (to fluid-fixed by default) was clearly based on the user survey, which demonstrated that a majority of users change this setting. This is not the case with code wrapping.
Now, these are defaults and people may unwittingly stick to them forever - or worse, be put off from using TiddlyWiki. But the safer option is to keep it as-is, because the many people who went into Theme Tweaks did not change the wrapping setting.