Your help is needed to test v5.4.0

4 posts were split to a new topic: V5.4.0 prerelease - Import is much slower now

It seems Uglify from @Flibbles does not work with new release. This is uglified empty.html with few tiddlers

Relink won’t work either. Not with any new syntax.

If I had known that by making those plugins, I was signing myself up for perpetual updates with every major release of TW, I… I probably still would have done it. I have a problem.

But those plugins will have to wait a minute. I’m working on other stuff right now. Taking a TW break for a while.

8 Likes

3 posts were split to a new topic: Test locally built empty.html with prerelease libraries

3 posts were split to a new topic: V5.4.0 prerelease - Zoomin Story View - Close All triggers RSOD

I agree with this. I strongly prefer wrapping of code blocks by default. I don’t like having to use the horizontal scrollbar on all the codebody: yes tiddlers.

But if that is the way it has to be, I can configure it in all my wikis post 5.4

1 Like

The only complaint I have so far is that the shadow $:/themes/tiddlywiki/vanilla/options/codewrapping text was changed from pre-wrap to pre in the core. This was an issue for me, because probably due to some of my modifications the pre setting doesn’t look well with longer code lines flowing out of the tiddler area to the right. Everything is as it used to be on the pre-wrap setting.
If the default setting was changed on purpose, I’m alright with that, I can imagine why the no wrap could be better as default.

Edit: I found the PR that changed this default: [v5.4.0] Update configuration defaults by Jermolene · Pull Request #9107 · TiddlyWiki/TiddlyWiki5 · GitHub

There is some discussion too. So if you disagree with the new default – Lets us know.


Also related is PR: Fix unwrapped oveflowed code blocks not showing scroll bars when setting "Wrap long lines in code blocks" to "No" in "Theme tweaks" by Leilei332 · Pull Request #8413 · TiddlyWiki/TiddlyWiki5 · GitHub

But is did not change the default shadow. I can not find the PR, that changed this value. … That’s strange.
IMO the default should be “Wrap long lines in code blocks : Yes” … We only needed to change this one for easy testing the PR.

Long lines should look like this. … So if your wiki shows text outside of the tiddler, you need to check your Style sheet settings.

The default can be changed in

ControlPanel → Appearence → Theme Tweaks → Warp long lines in code blocks

Tested on my main wiki and nothing looks broken.
Not having the tidgraph problem reported above.

Pre-release documentation for Calls says:

Calls can be used in filters. The text is not wikified which again means that the parameters will be ignored.

Testing using <<now>> macro with : vs = param handling:

<$let fmt="YYYY0MM0DD0hh0mm0ss0XXX">

#literal unnamed param<br><<now YYYY0MM0DD0hh0mm0ss0XXX>>
#literal named param using `:`<br><<now format:'YYYY0MM0DD0hh0mm0ss0XXX'>>
#variable named param using `=`<br><<now format=<<fmt>>>>
#filter with unnamed param<br><$list filter="[<now YYYY0MM0DD0hh0mm0ss0XXX>]"><<currentTiddler>></$list>
#filter with literal named param using `:`<br><$list filter="[<now format:'YYYY0MM0DD0hh0mm0ss0XXX'>]"><<currentTiddler>></$list>
#filter with variable named param using `=`<br><$list filter="[<now format=<<fmt>>>]"><<currentTiddler>></$list>

produces this output:

literal unnamed param
20260224084305886
literal named param using :
20260224084305886
variable named param using =
20260224084305886
filter with unnamed param
20260224084305886
filter with literal named param using :
20260224084305886
filter with variable named param using =
Filter error: Missing [ in filter expression

Thus, calls in filters using the unnamed param or : literal named param syntax still work, even though Calls seems to say otherwise.

Multi-valued variables clarification: do filter operators each have to be individually updated in order to support MVVs?

The MVV docs say “Certain filter operators can accept multi-valued parameters: function Operator, title Operator”. Does that mean that these are the only operators that will understand MVVs, and everything else treats them as single values?

(If so, that severely limits their possibilities…)

Found 2 issues in my wiki:

by @telmiger (Plugins — Utilities for TiddlyWiki) not working anymore:

smooth Scrolling through the wiki is not possible - it keeps freezing, even when I use the scrollbar-thumb

I tried installing Simple Search in the pre-release and it looked to work as expected. Can someone else please confirm if there is an issue with this plugin and v5.4.0 pre-release?

Upgrading to v5.4.0 turns the links from Link to Tabs blue. This can be a little distracting in some wikis.

1

2

Yea, I’ve seen that already. IMO it needs to be fixed at the plugin level. – That’s expected, but it may also happen for other plugins.

3 posts were split to a new topic: V5.4.0 prerelease - Several block-quote syntax blocks are slow

Most operators operate on input and don’t make much use of parameters. Only parameters need special support for handling MVV. Which operators did you have in mind which you want to pass MVV as parameter?

A few notes I’ve found running the updater against my wiki. 5.4.0 RSOEs my wiki currently:

  • the “Vis” plugin from @Flibbles’s graph plugin complains when updating a wiki (but I can’t reproduce in the sample for that plugin):
[Error] Script error.
	(anonymous function) (upgrade-4.html:5208)
	(anonymous function) (upgrade-4.html:5260)
	(anonymous function) ($:/plugins/flibbles/vis-network/vis.js:39)
  • Maybe related, or unrelated, but I hit an error in the transclusion widget immediately after:
[Error] ReferenceError: Can't find variable: alt
	(anonymous function) ($:/core/modules/widgets/transclude.js:462)
	(anonymous function) ($:/core/modules/widgets/widget.js:691)
	(anonymous function) ($:/core/modules/widgets/element.js:83)
	(anonymous function) ($:/core/modules/widgets/widget.js:691)
	(anonymous function) ($:/core/modules/widgets/widget.js:72)
	(anonymous function) ($:/core/modules/startup/render.js:72)
	(anonymous function) ($:/core/modules/startup/render.js:74)
	(anonymous function) (upgrade-4.html:7640)
	(anonymous function) (upgrade-4.html:7587)
	(anonymous function) (upgrade-4.html:7597)
	(anonymous function) (upgrade-4.html:7777)
	(anonymous function) (upgrade-4.html:6782)
	(anonymous function) (upgrade-4.html:7775)
	_boot (upgrade-4.html:7784)
	Global Code (upgrade-4.html:7796)

I’ll see if I can get a minimal reproducing case for this (this is a private wiki).

@saqimtiaz There is an issue in the edit-template of the pre-release when quick-image plug-in is installed as shown in the screenshot below

Here is a test-wiki - https://tw-5-4-0-test.tiddlyhost.com/ - This test wiki is just the pre-release with quick-image plug-in installed

The plugin is experimental and overrides core tiddlers, so this is to be expected until the plugin is updated. This is not an issue with the core.

I may have spoken too soon, that looks like it could be a parsing issue. Will need to investigate.

This doesn’t seem to parse accurately on the pre-release:

\widget $dropzone(importTitle, autoOpenOnImport, contentTypesFilter, class, enable, filesOnly, actions)
	<$genesis
		$remappable="no" 
		$type="$dropzone"
		importTitle=<<importTitle>>
		autoOpenOnImport="no"
		contentTypesFilter=<<contentTypesFilter>>
		class=<<class> enable=<<enable>>
		filesOnly=<<filesOnly>>
		actions="<$action-log/>"
	>
		<$slot $name="ts-raw"/>
	</$genesis>
\end

<$dropzone/>

There is a missing closing bracket > in the override of the edit template for the attribute class for the genesis widget in the plugin. The parser has seen some changes and seems less forgiving of such errors that in the past.