Tabs macro viewtemplate question

,
#5

Ahh ok- awesome, thanks @Springer :grinning_face_with_smiling_eyes:

One other minor question I have though, is there a specific way I need to setup the body transclusion so that stylesheets and the like render with cody-body formatting?

#6

One followup:

If your notes ever include any styling or other complexity, then you may be disappointed to see plain text in that tab.

Instead, make the notes-tab wikify the content, like so:

<$wikify name="ToWikify" text="""{{{ [<currentTiddler>get[notes]] }}}"""><<ToWikify>></$wikify>
#7

@Springer covered nearly everything I was going to say, so I’ll just add that you could also write a more generic filter like this…

[<currentTiddler>fields[]filter<fields-as-tabs>addprefix[$:/wiki/ui/ViewTemplate/tabbed/]]

where fields-as-tabs defines the list of fields you want to include…

\define fields-as-tabs() [{!!title}] :intersection[enlist[field-1 field-2 another-field]]

1 Like
#8

I’m afraid this is a level far beyond my understanding :sweat_smile:

Edit: Also, I’ve noticed a critial error with my tab viewtemplate that I don’t know how to fix…

When I drag a tiddler in to import, it shows in <code> rather than as the normal import page.

#9

To make the body transclusion follow the cascade conditions (which is what makes code-body “yes” tiddlers show as code, etc.), change your tiddler-body tab so that instead of just {{!!text}} it has:

<$transclude field="text" tiddler={{{ [<currentTiddler>]  :cascade[all[shadows+tiddlers]tag[$:/tags/ViewTemplateBodyFilter]!is[draft]get[text]] :and[!is[blank]else[$:/core/ui/ViewTemplate/body/default]] }}} />

(Note, your current solution — in the form you attached as a json above — is employing a hide-body trick, and my tip here requires you not to change that. If you choose to have the tiddler-body tab display according to the cascade condition, you should not ALSO use the cascade condition to always show tiddler body as this set of tabs (which is something I suggested earlier in this thread). If you combined that earlier advice together with my recent follow-up tip (without further modifications), then you’d have a house-of-mirrors effect of having a set of tabs within a set of tabs, unto infinity, within the “body” tab of each tiddler ;))

#10

I imagine you meant to quote my code, not @Springer’s, which is quite neat and self-explanatory, I think! Breaking it down:

  • fields[] retrieves all the existing fields of the input tiddler(s) - in this case, that’s <<currentTiddler>>
  • filter<> runs all the input values (here, the list of field names) through a secondary filter—here, that’s defined in the variable fields-as-tabs, which we’ll come back to! If the secondary filter produces any result for a given field name, that field name (not the result of the secondary filter) will be passed on to the next step of the original filter. (This is in contrast to subfilter, which passes on the result of the secondary filter.)
  • addprefix adds the prefix $:/wiki/ui/ViewTemplate/tabbed/ to each input value it receives.

And in filter<fields-as-tabs>…

  • [{!!title}] = the input value - in this case, the name of each field on <<currentTiddler>>
  • :intersection finds the values that appear in both the filter run it precedes and the previous one - that is, only the field names that appear in the list field-1 field-2 another-field

So if you used this filter on a tiddler with fields field-a, field-1, and another-field…

  • [<currentTiddler>fields[]... gives field-a field-1 another-field
  • filter<fields-as-tabs> gives field-1 another-field. field-a is excluded because it doesn’t appear in [enlist[field-1 field-2 another-field]].
  • addprefix[$:/wiki/ui/ViewTemplate/tabbed/] gives $:/wiki/ui/ViewTemplate/tabbed/field-1 $:/wiki/ui/ViewTemplate/tabbed/another-field — which are, hopefully, tab templates for displaying the contents of field-1 and another-field respectively.
#11

So when you refer to the hide-body trick, are you referring to the data-tags display:none or the reveal widget? Just asking so I know which one to change in order to not have that infinite tab bug happen (again lol) because it crashed my wiki last time :sweat_smile:

Also, will the cascase above also resolve the issue with the $:/import tiddler?

#12

I’m referring to your stylesheet trick: .tc-tiddler-body {display: none;}

which is what makes it non-redundant to put your tiddler’s text field into a tab in your custom view template…

I’m not seeing any import bug when I set your json combination up at tiddlywiki.com (though you probably have made changes that I’m not tracking completely).

So I’m not sure what to suggest, except that you can troubleshoot by dragging any subset of tiddlers there (to tiddlywiki.com), and seeing whether things behave ok when you try an import. If so, then the problem is something other than that particular set of tiddlers.

#13

Since @Justin_H responded with a :thinking: emoji, and since I like the basic idea here, I just tossed @etardiff’s suggestions into a demo here:

https://quick-demo.tiddlyhost.com/#tabbyView%20demo:[[tabbyView%20demo]]%20%24%3A%2Fwiki%2Fstylesheets%2FViewTemplate%2Ftabbed

All of the tiddlers involved in this solution are tagged with tabbyView. So if you drag that tag pill to your wiki, they should all come over and behave well together, and you can deconstruct them to see how they work, change which fields get included, etc.

(For what it’s worth, I’m still not seeing any problem with how the import tiddler displays.)

Enjoy!

2 Likes
#14

Ah, ok- thanks for clarifying on that!

Alrighty, just got home, lemme see if I can recreate the import issue I was running into, and I will explain what I find.

Edit: Ok! so, to recreate the issue, drag n drop this json package of tiddlers into tiddlywiki.com/empty, then from another tiddlywiki, drag any tiddler into the tiddlywiki.com/empty wiki, and it will show the $:/import tiddler as json, not the normal view.

tiddlers.json (1.9 KB)

#15

I like your thinking here @Justin_H and will look at your idea further, a few quick notes;

  • As discussed here RFC: Conditional UI elements Tabs/buttons and more and illustrated here https://conditional-elements.tiddlyhost.com/ I have recently poroposed extending the tabs macro and others UI elements to allow an optional condition field in tabs.
    • Just drag the $:/core/macros/tabs to your wiki (Be backup safe),
    • Thus your notes tab would have a condition of [all[current]has[notes]] and it would be displayed if the current tiddler has the notes field and it is “not blank”.
  • I recomend you always have some kind of condition or indicator to show tiddlers that will have these tabs, it is importiant to be able to enable or disable it (any additional feature) on a given tiddler, because there will inevitably be tiddlers on which you need to.

One thing I realised is what you are doing is not dissimilar to the tabs in the info button drop down.

  • So I was thinking what if your tabs (with conditions) had the tag $:/tags/TiddlerInfo then they would be available in the info dropdown. I know this is not yet what you are after, but then consider;
  • What if we then had a tool info dropdown to select any one or more of these tabs on the tiddler itself, as you are doing?
  • They will be available in the info drop down and you can add them to the tiddler selectivly.
    • To achive this we would have a list field eg; tabs-here containing the tiddler titles of all selected tabs (also a filter), that can be reordered and other methods could be used to add tabs to this list. eg [tags[standard-tabs]]

If you are interested in this idea, let me know and I will work on it sooner rather than later.

[Edited] and we would leverage the body cascade as @Springer suggests.

I have found this is a good mechanisium to implement many of my solutions so are going ahead now.

1 Like
#16

Justin, the version of the body tab that you’ve got in that uploaded json doesn’t use the cascade condition that I suggested above (and which I implemented in my demo). See the implementation for the body tab here.

1 Like
#17

Huh, that’s an interesting idea, i would imagine you could do this by checkboxes, where unchecked is $:/tags/TiddlerInfo and checked is $:/tags/TiddlerTab(or other tag name?)

not neccesarily something I would use at the moment but I’m sure it has it’s utility for others.

@Springer oops, you’re right, I missed that, thank you- the issue doesn’t occur with yours at all :grinning_face_with_smiling_eyes:

#18

Actually I have some other mechanisms. I have implemented the initial design here https://conditional-elements.tiddlyhost.com/

  • The home tiddler has had tabs set, you can see where to adjust it via the info button.
  • For your requirements you would simply tag a tiddler you want to appear as a tab in the tiddler (give it a caption) and tag with $:/tags/TiddlerInfo.
  • Then click on the info tab, select the first tab and select your tiddler to appear as a tab. If you want the standard body as a tab also select content as well.
    • You can also drag and drop reorder below that.
#19

Thought I would return with a new question regarding the tabbed layout.

Is there a way to use a filter for when it’s applied to tiddlers, like how you can with $:/tags/StoryTiddlerTemplateFilter with a filter like [!is[system]then[$:/wiki/ui/ViewTemplate/tabbed]] or [tag[Topic (Tiddler)]then[$:/wiki/ui/ViewTemplate/tabbed]] ?

#20

Yes, you can use cascades with the View Template Body as well. Make a new tiddler with your chosen filter, tag it $:/tags/ViewTemplateBodyFilter, and make sure that it appears above $:/config/ViewTemplateBodyFilters/default in the tag dropdown.

You can access any of the template cascades via the Control Panel → Info → Advanced → Cascades, BTW!

1 Like
#21

Yes the truly cascade-based solution is the one that I initially assumed you’d want, back toward the beginning of this thread…

But now you will need to change the body tab element back to a basic transclusion of the text field (not itself appeal to the cascade condition — otherwise, you get some kind of regress of a body inside a body inside a body).

So, you want instead to have the template (the whole set of tabs) display only as the body area (some or all) non-system tiddlers. All good; that avoids the risk of bricking your import dialog and other essential parts of the wiki.

However, you then also need to REMOVE that stylesheet that makes the body field disappear, as quoted in your first post:

title: stylesheet
tags: $:/tags/Stylesheet
body: """ 
.tc-tiddler-body {display: none;} 
"""
2 Likes
#22

@etardiff
Ah, thank you- I had used that tag before but thought I was doing something wrong when it began to mirror my tabs, but that was due to the cascade situation Springer pointed out after your response.

@Springer
Initially yes it was, however the idea of being able to selectively apply the tabbed layout meant that I could use it for other ideas later down the line.

I’ve reverted the cascade design back to the transclusion, but I can’t figure out what I can do to replace the functionality of the fields to tabs, which I’m pretty sure relied on the cascade to turn into a tab that shows it’s text :confused:

#23

I just tweaked my demo for tabbyView, so that the template only applies (via the central TW cascade mechanism) to tiddlers that meet a certain condition, and the body tab within the template is a simple default transclusion.

You can drag the tag into your own project, and all the elements will come over. Even the cascade condition should come over fine, because I gave it a list-after field with the value
$:/config/ViewTemplateBodyFilters/code-body

Currently, the tabbyView template is set to apply ONLY to the set of tiddlers tagged tabbyView (so that the template doesn’t affect other demos on the same site). You can change the filter condition so that it applies to all non-system tiddlers, or whatever other condition you like.

2 Likes
#24

I appreciate the updated version, after taking a look at how you did it, I figured out what was wrong with my own approach, thank you for the help :grinning_face_with_smiling_eyes:

1 Like