Revived share plugin

[btheado]

@jeremyruston

This turned out to be straightforward; the commit with the fix is here . In 10 minutes or so the build should have completed and the links posted above will start working.

Thanks @jeremyruston. The links from the original post work still fine for me, but when I manually change the second hash in the url to %23 (to simulate receiving through email), then there is some undesirable behavior. See hello world test using percent 23.

It seems that startup/storylist.js is also picking up the location hash and it opens a “Missing tiddler” with a title matching the json in the hash.

There is some code in boot.js ($tw.utils.getLocationHash) which is checking for ‘#’ which might be related. See also:

1. Bug in location hash processing loses any characters after second # · Issue #3811 · TiddlyWiki/TiddlyWiki5 · GitHub
2. Fix bug when location hash contains a # by rmunn · Pull Request #4947 · TiddlyWiki/TiddlyWiki5 · GitHub
3. Document how to use double hashes for anchor links by rmunn · Pull Request #5149 · TiddlyWiki/TiddlyWiki5 · GitHub

Maybe the share plugin can convert the %23 back into the ‘#’? That way the boot.js code will trigger and prevent startup/storylist.js from seeing the json?