Thanks for reporting @Springer
The line should be visible even when not hovering over it
What browser are you using? I’ll try investigating…
Yes, the color is muted. The design can be discussed. I believe on hover the opacity of the line is 0.6
It’s because of the background attachments so that they bleed through a bit…
Maybe as a configuration option to opt in? Would that be ok?
I think it’s not necessary. IMO Users expect “dividers” to be draggable. As long as the line is visible, they will figure it our. – just my thoughts
I think it’s a matter of the display and not the browser. I do have a laptop, where the line is almost invisible. On my 2 PC monitors it is quite visible. So IMO it will highly depend on the monitor settings.
If there should be a hint vor new users, it would need to be an “opt-out” setting for advanced users, since new users do not know what to do.
I agree regarding clutter. I agree with other comments, if the line becomes visible - most people will know that it is draggable.
I love the resizable preview!
I personally am a minimalist. Visible would be good, but I would vote for the ability to set it to only visible on hover - which might also be good for those who do hardcore layout work etc.
Although I did not check current appearance on mobile, please remember that mobile platforms (and more generally touchscreens) don’t have “hover” events. So I think that, by default, resizer shouldn’t be completely invisible, at least not 100% transparent, unless explicitly configured by user.
Fred
Hi @tw-FRed
On mobile I’m planning with the @media (pointer: coarse) media query, which should cover all touch devices.
In that case the sliders will be shown differently, for the sidebar resizer there’s already a different design in those cases but it’s just for demo, nothing settled, for the other sliders it’s to decide how they should look like
I do not think so. For me it is OK as it is atm. – You may ask Jeremy at the GH thread, if a new setting will be merged.
----- Slightly OT
The main problem I see with the current layout settings is, that they are so complicated, that very view users can actually use them in the right way.
I personally use a bundle from the browser bookmarks bar that can import my personal settings to every wiki. I did create that bundle a year ago and never touched it since then.
I think your resizer will make that bundle obsolete. I also think that it will make the “Sidebar layout” setting obsolete. It is only there for backwards compatibility reasons.
I think, by default we should completely hide the layout size related stuff behind a “Legacy settings” button using a reveal, to make the Theme Tweaks page much simpler.
---------- end of OT
just some thoughts.
-m
I’ve added settings for now for the slider opacity, they are in the Control Panel under Appearance > Theme Tweaks
The main problem as I see it is, that an empty wiki has by default fixed-fluid mode active and fixed-fluid mode is an advanced mode in comparison to fluid-fixed.
I don’t think fixed-fluid mode is obsolete. It lets users set the layout more precisely, a gap between story-river and sidebar can be accomplished and the sidebar is fluid, which means that, when resizing the browser window, the sidebar resizes and the story-river keeps its width. In fluid-fixed mode, when resizing the browser, the sidebar keeps its width and the story-river resizes.
Also, in fixed-fluid mode the tiddler width can be set, in fluid-fixed mode the tiddler width is 100%.
I don’t think we should do that, again, I think we should make fluid-fixed the default sidebar layout as it’s the easier one and give users the possibility to change to fixed-fluid if they want to.
What I’d like to do is hiding the metrics that don’t have anything to do with fluid-fixed mode if fluid-fixed mode is chosen.
Long, long overdue.
Hi @CodaCoder
That is now done, it’s already in the preview
In the meantime I found some minor bugs and fixed them.
Hi,
I just tried latest preview, and resizer doesn’t work any more. Mouse pointer changes to a “resizer” pointer like before, but dragging it doesn’t resize anything, be it in “Fluid, fixed” or “Fixed, Fluid”, with SideBar on left or right side.
Tested with Firefox and Vivaldi on linux.
Fred
Thanks for reporting @tw-FRed
in fact the problem came from a bit of refactoring and trying to resolve one problem I introduced this one.
It is now fixed
I love current state of the demo site!
I didn’t play much with config settings in ControlPanel, because what I’d expect of a resizer is to be usable “out of the box”, without resorting to manual configuration. Current version does exactly that, and I can tweak river/sidebar ratio just with my mouse.
Thanks for this great enhancement @BurningTreeC, I really hope your work will land in the core soon!
Fred
Hello all,
now I had to add some Javascript so that the editor doesn’t redraw all the time when the editor slider gets used.
Practically, if the class of the editor changes it doesn’t fully refresh anymore but only assigns the new classes to the editor DomNode. That’s something we already do in certain widgets but not all have yet seen this upgrade.